Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new KvikIO compatibility mode "AUTO" #547

Merged
Changes from 1 commit
Commits
Show all changes
52 commits
Select commit Hold shift + click to select a range
0b69ff3
Add ALLOW mode
kingcrimsontianyu Nov 7, 2024
4eb21f5
Update
kingcrimsontianyu Nov 8, 2024
207b5dd
Update
kingcrimsontianyu Nov 8, 2024
a430d5b
Make the changes non-breaking
kingcrimsontianyu Nov 8, 2024
26431fb
Add comments
kingcrimsontianyu Nov 8, 2024
a76c3da
Add comments
kingcrimsontianyu Nov 8, 2024
bcbf81e
Adjustment
kingcrimsontianyu Nov 8, 2024
17de218
Rename the compat mode
kingcrimsontianyu Nov 9, 2024
8e9b478
Further simplify the implementation
kingcrimsontianyu Nov 9, 2024
1d938bd
Update
kingcrimsontianyu Nov 9, 2024
6b16210
Further simplify
kingcrimsontianyu Nov 9, 2024
b71f7f6
Add unit test
kingcrimsontianyu Nov 10, 2024
8e04177
Use pre-commit to fix formatting
kingcrimsontianyu Nov 10, 2024
b0ae4ac
Update Python interface
kingcrimsontianyu Nov 10, 2024
c0c2139
Fix Python issue
kingcrimsontianyu Nov 10, 2024
5d18bc8
Update comment
kingcrimsontianyu Nov 10, 2024
7509233
Add Python unit test
kingcrimsontianyu Nov 10, 2024
a711589
Update Python unit test
kingcrimsontianyu Nov 10, 2024
4ed4031
Add more test
kingcrimsontianyu Nov 11, 2024
c747241
Cleanup
kingcrimsontianyu Nov 11, 2024
18e6fd7
Address reviewer comments
kingcrimsontianyu Nov 12, 2024
087a691
Lint
kingcrimsontianyu Nov 12, 2024
01ad65d
Fix comment
kingcrimsontianyu Nov 12, 2024
fbf5cd3
Reset compat mode state for file handle
kingcrimsontianyu Nov 12, 2024
385c0cb
Fix test
kingcrimsontianyu Nov 12, 2024
736d8ec
Address review comment
kingcrimsontianyu Nov 12, 2024
570350a
Address reviewer comments
kingcrimsontianyu Nov 13, 2024
9c6b649
Update the doc
kingcrimsontianyu Nov 13, 2024
0f353ef
Improve comments
kingcrimsontianyu Nov 13, 2024
f8fdd73
Remove compat inference from defautls
kingcrimsontianyu Nov 13, 2024
b6e70a3
Address compat mode in buffer
kingcrimsontianyu Nov 13, 2024
9621e1b
A happy update
kingcrimsontianyu Nov 14, 2024
b7ad8c8
Update examples
kingcrimsontianyu Nov 14, 2024
8d48eaa
Cleanup
kingcrimsontianyu Nov 14, 2024
6c58f88
Update for the batch
kingcrimsontianyu Nov 14, 2024
d3f93a3
Fix copyright lint error
kingcrimsontianyu Nov 14, 2024
d922b1d
Fix docs
kingcrimsontianyu Nov 14, 2024
84ac5ea
Fix header
kingcrimsontianyu Nov 14, 2024
70f2f79
Fix Sphinx doc issue. Improve string parsing for compat mode
kingcrimsontianyu Nov 14, 2024
34c594d
Rename compat mode related functions
kingcrimsontianyu Nov 15, 2024
f34ea86
Fix compat mode. Update doc
kingcrimsontianyu Nov 15, 2024
74dc84c
Futher tweaks
kingcrimsontianyu Nov 15, 2024
f89965e
Update
kingcrimsontianyu Nov 15, 2024
b5c3a46
Revert
kingcrimsontianyu Nov 15, 2024
ca4bf22
Final touch
kingcrimsontianyu Nov 15, 2024
9e69c22
Simplify implementation
kingcrimsontianyu Nov 16, 2024
032b075
Further cleanup
kingcrimsontianyu Nov 16, 2024
d332da4
Improve doxygen doc
kingcrimsontianyu Nov 16, 2024
64490d2
Rename a compat mode function according to reviewer suggestion
kingcrimsontianyu Nov 19, 2024
95accfe
Remove WHATEVER as AUTO's alias
kingcrimsontianyu Nov 19, 2024
efae9b0
Cleanup
kingcrimsontianyu Nov 19, 2024
20f4373
Addres reviewers comment
kingcrimsontianyu Nov 19, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Addres reviewers comment
kingcrimsontianyu committed Nov 19, 2024
commit 20f43736acf576fbf506d8168ad49e946985b2bd
9 changes: 3 additions & 6 deletions cpp/include/kvikio/defaults.hpp
Original file line number Diff line number Diff line change
@@ -262,12 +262,9 @@ class defaults {
*/
static bool is_compat_mode_preferred(CompatMode compat_mode)
{
if (compat_mode == CompatMode::ON ||
(compat_mode == CompatMode::AUTO &&
defaults::infer_compat_mode_if_auto(compat_mode) == CompatMode::ON)) {
return true;
}
return false;
return compat_mode == CompatMode::ON ||
(compat_mode == CompatMode::AUTO &&
defaults::infer_compat_mode_if_auto(compat_mode) == CompatMode::ON);
}

/**