Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace FindcuFile with upstream FindCUDAToolkit support #542

Merged

Conversation

KyleFromNVIDIA
Copy link
Contributor

CMake's FindCUDAToolkit has supported cuFile since 3.25. Use this support and remove the custom FindcuFile module.

CMake's FindCUDAToolkit has supported cuFile since 3.25. Use this
support and remove the custom FindcuFile module.
@KyleFromNVIDIA KyleFromNVIDIA requested a review from a team as a code owner November 6, 2024 19:27
@KyleFromNVIDIA KyleFromNVIDIA added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Nov 6, 2024
@KyleFromNVIDIA KyleFromNVIDIA requested a review from a team as a code owner November 7, 2024 23:20
@KyleFromNVIDIA KyleFromNVIDIA marked this pull request as draft November 8, 2024 15:46
@KyleFromNVIDIA KyleFromNVIDIA marked this pull request as ready for review November 9, 2024 00:17
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I have a couple of suggestions, but I trust you to apply them or not appropriately. I don't need to review again.

cpp/CMakeLists.txt Outdated Show resolved Hide resolved
cpp/CMakeLists.txt Show resolved Hide resolved
@KyleFromNVIDIA
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 0f7c0c7 into rapidsai:branch-24.12 Nov 9, 2024
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants