Simplify _to_string
encoding of Python str
s
#498
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes a few improvements to the Cython logic of
_to_string
:str
: This allows Cython to use CPython API relevant for the specific type (it will check type on entry)is not None
check first: This way when Cython generates additionalNone
checks inside the branch, the compiler can optimize them outstr
'sencode
method: Cython makes a direct CPython call to generatebytes
and then extracts the pointer and size for C++ to copy