Fix release-after-main bug in get_primary_cuda_context
#472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsbk
added
bug
wence-
approved these changes
Sep 25, 2024
cpp/include/kvikio/utils.hpp
Outdated
Comment on lines
31
to
37
| // Macros used for defining symbol visibility, only GLIBC is supported. | ||
| // Since KvikIO is header-only, we rely on the linker to disambiguate inline functions | ||
| // that have (or return) static references. To do this, the relevant function must have | ||
| // `__attribute__((visibility("default")))`. If not, then if KvikIO is used in two | ||
| // different DSOs, the function will appear twice, and there will be two static objects. | ||
| // See <https://github.com/rapidsai/kvikio/issues/442>. | ||
| #if (defined(__GNUC__) && !defined(__MINGW32__) && !defined(__MINGW64__)) |
There was a problem hiding this comment.
nit: Can we also support clang (https://clang.llvm.org/docs/AttributeReference.html#visibility) given the various people compiling on macos?
There was a problem hiding this comment.
Actually, clang also defines __GNUC__ by default but I guess adding defined(__clang__) is good since __attribute__((visibility(...))) is valid clang code as well.
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #442