Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build.sh: --pydevelop #429

Merged
merged 3 commits into from
Aug 8, 2024
Merged

build.sh: --pydevelop #429

merged 3 commits into from
Aug 8, 2024

Conversation

madsbk
Copy link
Member

@madsbk madsbk commented Aug 5, 2024

Adding the --pydevelop argument to build.sh

@madsbk madsbk added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Aug 5, 2024
@madsbk madsbk marked this pull request as ready for review August 5, 2024 13:34
@madsbk madsbk requested a review from a team as a code owner August 5, 2024 13:34
@madsbk madsbk requested a review from msarahan August 5, 2024 13:34
bdice
bdice approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small suggestion for moving some code. Otherwise LGTM.

@madsbk
Copy link
Member Author

madsbk commented Aug 8, 2024

/merge

@rapids-bot rapids-bot bot merged commit 260eff7 into rapidsai:branch-24.10 Aug 8, 2024
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@msarahan msarahan Awaiting requested review from msarahan msarahan is a code owner automatically assigned from rapidsai/packaging-codeowners

Assignees
No one assigned
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@madsbk @bdice