Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix O_DIRECT in defined #416

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Conversation

jakirkham
Copy link
Member

@jakirkham jakirkham commented Jul 24, 2024

There was a minor typo here. This fixes that

xref: #404 (comment)

@jakirkham jakirkham requested a review from a team as a code owner July 24, 2024 16:38
@jakirkham jakirkham added bug Something isn't working non-breaking Introduces a non-breaking change labels Jul 24, 2024
Copy link
Member

@madsbk madsbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@jakirkham
Copy link
Member Author

jakirkham commented Jul 24, 2024

Thanks Mads! 🙏

One of the devcontainer jobs ran into a network error. Normally would wait for the rest to finish before restarting. However the CI queue has been a bit long as of late. So preemptively canceled the jobs and restarted

The devcontainer job should start relatively quickly (and hopefully not have a network error this time). Likely the remaining jobs are not much further back in the CI queue than we already were

Edit: Yep that cleared up the devcontainer job. Now just waiting for tests

@jakirkham
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit ec5e568 into rapidsai:branch-24.08 Jul 24, 2024
60 of 61 checks passed
@jakirkham jakirkham deleted the fix_o_direct branch July 24, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants