Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add wheel output #369

Merged
merged 82 commits into from
Jun 19, 2024
Merged
Changes from 1 commit
Commits
Show all changes
82 commits
Select commit Hold shift + click to select a range
d650fa7
WIP: add wheel output
msarahan Apr 17, 2024
1faa517
reorganize python folder to allow for libkvikio wheel
msarahan Apr 17, 2024
ea1992b
fix matrix_filter in the wrong place
msarahan Apr 17, 2024
3b35c05
fix executability and add missing pyproject.toml
msarahan Apr 17, 2024
3f9e1fe
fix version file location
msarahan Apr 17, 2024
a3e25f1
fix missing lib files
msarahan Apr 22, 2024
f8b55e0
remove load.py (kvikio is header-only)
msarahan Apr 23, 2024
1c7ebd9
renaming workflows for consistency. Fix path for build.sh python
msarahan Apr 30, 2024
f3cfff0
straighten out paths from python deeper nesting
msarahan Apr 30, 2024
3dceb00
linting cmake format
msarahan Apr 30, 2024
4ebecce
add librmm wheel dep from PR, disable cmake find debugging
msarahan May 1, 2024
9206dcd
adapt devcontainer run to account for different python package path
msarahan May 1, 2024
3298a1a
adjust cpm path; add cpm init to libkvikio wheel
msarahan May 1, 2024
5002499
fix relpath to findcufile
msarahan May 1, 2024
0a9b650
rapids cuda init architectures fix
msarahan May 1, 2024
eebdb55
Apply suggestions from code review
msarahan May 3, 2024
7f2a9d7
adjusting dependencies and wheel tagging
msarahan May 3, 2024
e016651
remove build deps from py_wheel_cpp
msarahan May 3, 2024
e056546
remove findCufile in libkvikio wheel cmakelists
msarahan May 3, 2024
55349a0
add wheel-python-tests in pr.yaml
msarahan May 3, 2024
3bc31e2
comment librmm inclusion
msarahan May 3, 2024
1249409
fix dependency on scikit-build for wheel
msarahan May 3, 2024
430ffd2
fix dependency on scikit-build for wheel
msarahan May 3, 2024
977d905
fix dependency on scikit-build for wheel
msarahan May 3, 2024
28f0dbd
add wheel dep
msarahan May 3, 2024
4fd111f
wheel has to be installed in build scripts
msarahan May 3, 2024
e2e73b8
wheel has to be installed in build scripts
msarahan May 3, 2024
550b21d
fix s3 download cpp wheel filename
msarahan May 3, 2024
71ba140
move libkvikio wheel to build reqs for kvikio wheel (header-only!)
msarahan May 3, 2024
33d5b8a
add wheel.py-api to libkvikio wheel
msarahan May 6, 2024
04801ef
fix missing -cuXY version for libkvikio
msarahan May 6, 2024
ff4e2bb
add install_aliased_imported_targets for nvcomp
msarahan May 7, 2024
abef47d
style
msarahan May 7, 2024
4331fd8
try to get CMake install_aliased_imported_targets working
msarahan May 7, 2024
899f249
remove unused get_nvcomp.cmake
msarahan May 7, 2024
ab4deb5
fix wrong WheelHelpers.cmake
msarahan May 7, 2024
a048172
reorganize python kvikio cmake
msarahan May 7, 2024
a58f445
restore get_nvcomp.cmake, move WheelHelpers.cmake
msarahan May 7, 2024
e8d1f22
typo in cmake thirdparty include
msarahan May 7, 2024
891c1ce
set cython lib dir
msarahan May 7, 2024
a8d7377
install nvcomp stuff into _lib subfolder alongside cython .so's
msarahan May 7, 2024
f4fbf11
add simple wheel install/test script
msarahan May 7, 2024
5e1f76b
Merge remote-tracking branch 'upstream/branch-24.06' into wheel-build
msarahan May 7, 2024
a33f3fa
chmod +x test_wheel.sh
msarahan May 7, 2024
efa116e
fix nesting too deep in test folder
msarahan May 7, 2024
5eb6b80
Apply suggestions from code review
msarahan May 7, 2024
798c60b
fix cuda-python not adjusting for cuda version
msarahan May 7, 2024
de87c1c
adjust more copyright dates
msarahan May 7, 2024
2b22c5a
add sed for cupy-cuda11x -> cupy-cuda12x on cuda 12
msarahan May 7, 2024
3d97ce3
add early cmake exit in libkvikio wheel if kvikio is already available
msarahan May 8, 2024
0860a99
add wheel publishing in build.yaml
msarahan May 8, 2024
9b89b29
cmake style fix
msarahan May 8, 2024
0e4beee
Update .github/workflows/build.yaml
msarahan May 8, 2024
649397d
Merge branch 'branch-24.06' into wheel-build
hcho3 May 28, 2024
d04de8b
Merge branch 'branch-24.08' into wheel-build
hcho3 Jun 4, 2024
d82635e
Bump libkvikio version
hcho3 Jun 6, 2024
619b9a1
Merge remote-tracking branch 'origin/branch-24.08' into wheel-build
hcho3 Jun 6, 2024
bbed671
Use latest workflows
hcho3 Jun 6, 2024
3dce076
Address reviewers' comments
hcho3 Jun 6, 2024
ff2182a
Fix formatting
hcho3 Jun 6, 2024
1b415f0
Defer to existing FindcuFile module
hcho3 Jun 6, 2024
3d1ac24
Remove unneeded build.sh
hcho3 Jun 6, 2024
8f058b9
Apply suggestions from code review
hcho3 Jun 7, 2024
ccbfd22
Removed outdated comment
hcho3 Jun 7, 2024
84d9e33
Use a separate build.sh
hcho3 Jun 7, 2024
eb127c4
Merge branch 'branch-24.08' into wheel-build
hcho3 Jun 7, 2024
e5c322b
Merge branch 'branch-24.08' of github.com:rapidsai/kvikio into wheel-…
msarahan Jun 17, 2024
5b9da4a
rapids-build-backend for python extension-only wheel
msarahan Jun 17, 2024
7c83f47
fix dependencies-file relative path
msarahan Jun 17, 2024
e2e46fe
always set cython_lib_dir
msarahan Jun 17, 2024
cbfd5f5
attempt to cut out sed stuff that RBB obviates
msarahan Jun 17, 2024
a32ad58
add RBB for libkvikio
msarahan Jun 17, 2024
df85d25
install RBB in build_wheel_*scripts
msarahan Jun 18, 2024
db0ce3b
rbb in build deps for libkvikio
msarahan Jun 18, 2024
bf7dc54
tweak build-backend in libkvikio pyproject.toml
msarahan Jun 18, 2024
f461ab2
libkvikio dynamic dep for pyproject
msarahan Jun 18, 2024
5e2560b
allow alpha specs
msarahan Jun 18, 2024
dd2d246
clean up some unnecessary changes
msarahan Jun 18, 2024
5706ee3
revert WheelHelpers removal and add note about install_aliased_import…
msarahan Jun 18, 2024
b728c93
Apply suggestions from code review
msarahan Jun 18, 2024
5a8ab66
clean up extraneous skbuild stuff (from review)
msarahan Jun 18, 2024
3cf7f82
Apply suggestions from code review
vyasr Jun 18, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
tweak build-backend in libkvikio pyproject.toml
msarahan committed Jun 18, 2024

Verified

This commit was signed with the committer’s verified signature. The key has expired.
marekmosna Marek Mosna
commit bf7dc543e3313564f26564a629967e81a9fe9614
2 changes: 0 additions & 2 deletions dependencies.yaml
Original file line number Diff line number Diff line change
@@ -71,7 +71,6 @@ files:
includes:
- build-universal
- build-py
- rapids_build_skbuild
py_wheel_python:
output: pyproject
pyproject_dir: python/kvikio
@@ -84,7 +83,6 @@ files:
- build-py
- build-py-wrapper
- build-use-libkvikio-wheel
- rapids_build_skbuild
py_optional_test:
output: pyproject
pyproject_dir: python/kvikio
1 change: 0 additions & 1 deletion python/kvikio/pyproject.toml
Original file line number Diff line number Diff line change
@@ -115,7 +115,6 @@ requires = [
"cython>=3.0.0",
"libkvikio==24.8.*",
"ninja",
"rapids-build-backend>=0.3.0,<0.4.0.dev0",
"scikit-build-core[pyproject]>=0.7.0",
] # This list was generated by `rapids-dependency-file-generator`. To make changes, edit ../../dependencies.yaml and run `rapids-dependency-file-generator`.

3 changes: 2 additions & 1 deletion python/libkvikio/pyproject.toml
Original file line number Diff line number Diff line change
@@ -47,9 +47,10 @@ input = "libkvikio/VERSION"
regex = "(?P<value>.*)"

[tool.rapids-build-backend]
build-backend = "scikit_build_core.build"
dependencies-file = "../../dependencies.yaml"
requires = [
"cmake>=3.26.4",
"ninja",
"rapids-build-backend>=0.3.0,<0.4.0.dev0",
"scikit-build-core[pyproject]>=0.7.0",
] # This list was generated by `rapids-dependency-file-generator`. To make changes, edit ../../dependencies.yaml and run `rapids-dependency-file-generator`.