-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs #268
Docs #268
Conversation
Thanks Mads! 🙏 Think this will be of great help to users getting started here 🙂 Would it make sense to update this notebook ( #270 ) here too? Or should that be a separate PR? |
Let's do it in a separate PR, I like to test the notebook separately. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving ops-codeowner
file changes
@@ -0,0 +1,11 @@ | |||
Zarr | |||
==== | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be good to give a brief brief mention of what zarr is:
Zarr is a binary file format for chunked, compressed, N-Dimensional array. It is used throughout the PyData ecosystem and especially for climate and biological science applications.
Something like that ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sound good, added.
Co-authored-by: Benjamin Zaitlen <[email protected]>
@quasiben, I think I have addressed all your comments? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO it would be nice to include information about the environment variables like KVIKIO_NTHREADS
in the docs. They are not very visible, especially the default values.
Good point, added a Runtime Settings section |
This is great, thank you for adding this! |
/merge |
No description provided.