Manually open and close the cuFile driver #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsbk
added
bug
madsbk
changed the title
vuule
approved these changes
Jan 26, 2023
Comment on lines
+80
to
+81
| std::cerr << "Unable to close GDS file driver: " << cufileop_status_error(error.err) | ||
| << std::endl; |
There was a problem hiding this comment.
No, to avoid throwing an exception in the destructor, we print a warning instead
There was a problem hiding this comment.
Right, no exceptions in the dtor.
Posted the comment because libcudf does not do any std output, thought the same might hold for kvikio
|
Notice, the CI error is unrelated and fixed in #156 |
quasiben
approved these changes
Jan 26, 2023
|
rerun tests |
|
/merge |
vuule
pushed a commit
to vuule/kvikio
that referenced
this pull request
Nov 8, 2023
…dules-defining-getattr Always find the fast types/function corresponding to slow types/functions
rapids-bot bot
pushed a commit
that referenced
this pull request
Nov 1, 2024
Changes: - Adding Python bindings to `cuFileDriverOpen()` and `cuFileDriverClose()`. - We now [only open the cufile driver explicitly](#160) in CUDA versions older than v12.2. - Introducing `kvikio.cufile_driver.initialize()`, which open the cuFile driver and close it again at module exit. - Let CI fail if KvikIO wasn't built with cuFile support. * Except on cuda11.8+arm64; cuFile didn't support arm until cuda v12.4. - Some refactor and clean up! Authors: - Mads R. B. Kristensen (https://github.com/madsbk) Approvers: - Lawrence Mitchell (https://github.com/wence-) - Vyas Ramasubramani (https://github.com/vyasr) URL: #514
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cuFile is supposed to open and close the driver automatically but because of a bug in CUDA 11.8, it sometimes segfault.
Closes #159
cc. @vuule