Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Vyas Ramasubramani <[email protected]>
Co-authored-by: Bradley Dice <[email protected]>
  • Loading branch information
3 people authored Dec 4, 2024
1 parent c67cc37 commit ec2e68f
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions cpp/include/kvikio/file_handle.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,8 @@ class FileHandle {
throw std::runtime_error("Missing the cuFile stream api.");
}

// When checking for availability, we also check if cuFile's config file exist. This is
// because even when the stream API is available, it doesn't work if no config file exist.
// When checking for availability, we also check if cuFile's config file exists. This is
// because even when the stream API is available, it doesn't work if no config file exists.
if (config_path().empty()) {
if (requested_compat_mode == CompatMode::AUTO) { return true; }
throw std::runtime_error("Missing cuFile configuration file.");
Expand Down
2 changes: 1 addition & 1 deletion cpp/include/kvikio/shim/cufile.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ inline int cufile_version()
}
}
#else
constexpr bool cufile_version() { return 0; }
constexpr int cufile_version() { return 0; }
#endif

/**
Expand Down
4 changes: 2 additions & 2 deletions python/kvikio/kvikio/benchmarks/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,9 @@ def pprint_sys_info() -> None:
mem_total = format_bytes(pynvml.nvmlDeviceGetMemoryInfo(dev).total)
bar1_total = format_bytes(pynvml.nvmlDeviceGetBAR1MemoryInfo(dev).bar1Total)
if version == (0, 0):
libcufile_version = "unknown"
libcufile_version = "unknown (earlier than cuFile 1.8)"
else:
libcufile_version = f"{version[0]}.{version[1]}"
libcufile_version = ".".join(version)
gds_version = "N/A (Compatibility Mode)"
if props.is_gds_available:
gds_version = f"v{props.major_version}.{props.minor_version}"
Expand Down

0 comments on commit ec2e68f

Please sign in to comment.