Skip to content

Commit

Permalink
Replace local copyright check with pre-commit-hooks verify-copyright (#…
Browse files Browse the repository at this point in the history
…352)

The local `copyright.py` script is bug-prone. Replace it with a more robust centralized script from `pre-commit-hooks`.

Issue: rapidsai/build-planning#30

Authors:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

Approvers:
  - Mads R. B. Kristensen (https://github.com/madsbk)
  - Ray Douglass (https://github.com/raydouglass)

URL: #352
  • Loading branch information
KyleFromNVIDIA authored Mar 14, 2024
1 parent 30b1dc1 commit c6b2a4d
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 282 deletions.
15 changes: 9 additions & 6 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -51,12 +51,6 @@ repos:
args: ["-fallback-style=none", "-style=file", "-i"]
- repo: local
hooks:
- id: copyright-check
name: copyright-check
entry: python ./ci/checks/copyright.py --git-modified-only --update-current-year
language: python
pass_filenames: false
additional_dependencies: [gitpython]
- id: cmake-format
name: cmake-format
entry: ./cpp/scripts/run-cmake-format.sh cmake-format
Expand Down Expand Up @@ -92,6 +86,15 @@ repos:
hooks:
- id: rapids-dependency-file-generator
args: ["--clean"]
- repo: https://github.com/rapidsai/pre-commit-hooks
rev: v0.0.1
hooks:
- id: verify-copyright
files: |
(?x)
[.](cmake|cpp|cu|cuh|h|hpp|sh|pxd|py|pyx)$|
CMakeLists[.]txt$|
meta[.]yaml$
default_language_version:
python: python3
276 changes: 0 additions & 276 deletions ci/checks/copyright.py

This file was deleted.

0 comments on commit c6b2a4d

Please sign in to comment.