debug: BUILD_SHARED_LIBS ON

rapidsai · Nov 4, 2024 · 6d38bec · 6d38bec
1 parent 5e6f5e3
commit 6d38bec
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/cpp/CMakeLists.txt b/cpp/CMakeLists.txt
@@ -109,6 +109,7 @@ include(cmake/thirdparty/get_thread_pool.cmake)
 
 file(GLOB SOURCES "src/*.cpp")
 add_library(kvikio ${SOURCES})
+# target_link_options(kvikio PUBLIC "-Wl,--exclude-libs,libcurl.a")
 add_library(kvikio::kvikio ALIAS kvikio)
 
 target_include_directories(

diff --git a/cpp/cmake/thirdparty/get_libcurl.cmake b/cpp/cmake/thirdparty/get_libcurl.cmake
@@ -21,6 +21,7 @@ function(find_and_configure_libcurl)
     set(CACHE_HAS_BUILD_TESTING $CACHE{BUILD_TESTING})
   endif()
 
+  # set(CPM_DOWNLOAD_ALL ON)
   rapids_cpm_find(
     CURL 7.87.0
     GLOBAL_TARGETS libcurl
@@ -29,7 +30,7 @@ function(find_and_configure_libcurl)
     CPM_ARGS
     GIT_REPOSITORY https://github.com/curl/curl
     GIT_TAG curl-7_87_0
-    OPTIONS "BUILD_CURL_EXE OFF" "BUILD_SHARED_LIBS OFF" "BUILD_TESTING OFF" "CURL_USE_LIBPSL OFF"
+    OPTIONS "BUILD_CURL_EXE OFF" "BUILD_SHARED_LIBS ON" "BUILD_TESTING OFF" "CURL_USE_LIBPSL OFF"
             "CURL_DISABLE_LDAP ON" "CMAKE_POSITION_INDEPENDENT_CODE ON"
   )
   if(DEFINED CACHE_HAS_BUILD_TESTING)