convert_size2off(): fix different signedness

rapidsai · Apr 22, 2022 · 53c9b56 · 53c9b56
1 parent eaba165
commit 53c9b56
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/cpp/examples/CMakeLists.txt b/cpp/examples/CMakeLists.txt
@@ -17,7 +17,7 @@ target_include_directories(basic_io PRIVATE ../include ${cuFile_INCLUDE_DIRS})
 target_link_libraries(basic_io PRIVATE kvikio CUDA::cudart)
 
 if(CMAKE_COMPILER_IS_GNUCXX)
-  set(KVIKIO_CXX_FLAGS "-Wall;-Werror;-Wno-unknown-pragmas;-Werror=sign-compare")
+  set(KVIKIO_CXX_FLAGS "-Wall;-Werror;-Wno-unknown-pragmas")
   target_compile_options(
     basic_io PRIVATE "$<$<COMPILE_LANGUAGE:CXX>:${KVIKIO_CXX_FLAGS}>"
  )

diff --git a/cpp/include/kvikio/utils.hpp b/cpp/include/kvikio/utils.hpp
@@ -36,7 +36,7 @@ inline constexpr std::size_t page_size = 4096;
 
 [[nodiscard]] inline off_t convert_size2off(std::size_t x)
 {
-  if (x >= std::numeric_limits<off_t>::max()) {
+  if (x >= static_cast<std::size_t>(std::numeric_limits<off_t>::max())) {
     throw CUfileException("size_t argument too large to fit off_t");
   }
   return static_cast<off_t>(x);