Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] CPU Dask-SQL q05 #254

Merged
merged 1 commit into from
May 31, 2022
Merged

[REVIEW] CPU Dask-SQL q05 #254

merged 1 commit into from
May 31, 2022

Conversation

DaceT
Copy link
Contributor

@DaceT DaceT commented Apr 12, 2022

No description provided.

@DaceT DaceT changed the title Adding q05 to be reviewed [REVIEW] Adding q05 to be reviewed Apr 13, 2022
@DaceT DaceT changed the title [REVIEW] Adding q05 to be reviewed [REVIEW] CPU Dask-SQL q05 Apr 13, 2022
VibhuJawa
VibhuJawa reviewed Apr 25, 2022
View reviewed changes
gpu_bdb/bdb_tools/q05_utils.py
if isinstance(ml_input_df, cudf.DataFrame):
model_backend = cuml.LogisticRegression
else:
model_backend = sklearn.linear_model.LogisticRegression
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we update on this #248 why we chose sklearn instead of dask-ml . CC: @ChrisJar

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for testing this @ChrisJar

VibhuJawa
VibhuJawa approved these changes May 31, 2022
View reviewed changes
Copy link
Member

@VibhuJawa VibhuJawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VibhuJawa VibhuJawa merged commit bf31767 into rapidsai:main May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VibhuJawa VibhuJawa VibhuJawa approved these changes

Assignees
No one assigned
Labels
Waiting on Author
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DaceT @VibhuJawa