Adding query 2, 4 and 5 #243
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VibhuJawa
requested changes
Mar 10, 2022
I've added the changes now |
VibhuJawa
requested changes
Mar 14, 2022
| @@ -84,7 +87,11 @@ def main(data_dir, client, c, config): | |||
| result = result.persist() | |||
|
|
|||
| result = result.compute() | |||
| result_df = cudf.DataFrame({"sum(pagecount)/count(*)": [result]}) | |||
|
|
|||
| if isinstance(merged_df, cudf.DataFrame): | |||
There was a problem hiding this comment.
merged_df is a dask_cudf.DataFrame no , so below check is invalid.
I would suggest testing with both backed=GPU/CPU both so that we dont run into issues as were pointed out in PR #244
| @@ -94,11 +97,16 @@ def build_and_predict_model(ml_input_df): | |||
| results_dict = {} | |||
| y_pred = model.predict(X) | |||
|
|
|||
| results_dict["auc"] = roc_auc_score(y.values_host, y_pred.values_host) | |||
There was a problem hiding this comment.
We use cuML models for both CPU and GPU, we should use sklearn for CPU and cuML for GPU.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.