Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding queries 25, 26 and 30 to be reviewed #241

Merged
merged 4 commits into from
Mar 8, 2022

Conversation

DaceT
Copy link
Contributor

@DaceT DaceT commented Feb 28, 2022

No description provided.

Copy link
Member

@VibhuJawa VibhuJawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The good looks good to me and am requesting very minor changes.

Thanks for the great work on this @DaceT

gpu_bdb/bdb_tools/q25_utils.py Outdated Show resolved Hide resolved
gpu_bdb/queries/q25/gpu_bdb_query_25_dask_sql.py Outdated Show resolved Hide resolved
gpu_bdb/queries/q26/gpu_bdb_query_26_dask_sql.py Outdated Show resolved Hide resolved
Copy link
Member

@VibhuJawa VibhuJawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VibhuJawa VibhuJawa merged commit 9ae8a4d into rapidsai:main Mar 8, 2022
VibhuJawa added a commit that referenced this pull request Mar 14, 2022
VibhuJawa added a commit that referenced this pull request Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants