switch cupy_conf_mat to confusion_matrix #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beckernick
changed the title
ayushdg
approved these changes
Mar 1, 2021
There was a problem hiding this comment.
Thanks for the update @beckernick , In a followup PR the confusion matrix logic for q28 can be updated as well. ( I believe that's a distributed dask cm) which should be supported based on #rapidsai/cuml#1817
|
Ah, excellent. Let's do that, too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
cuml.metrics.confusion_matrixSee rapidsai/cuml#3567 for the need to explicitly cast to int32. After that issue is resolved, we can update this.