-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] BlazingSQL: Q02 - Remove ORDER BY tstamp #107
[REVIEW] BlazingSQL: Q02 - Remove ORDER BY tstamp #107
Conversation
Tested at sf 1K on the dgx201 (10 repetitions) all the executions show Correctness Assertion True
Also was tested at sf 10K using the RAPLAB (16 DGXs, as dgx103 have currently physical issues) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Good find
(wcs_click_date_sk * 86400 + wcs_click_time_sk) AS tstamp_inSec | ||
FROM web_clickstreams | ||
WHERE wcs_item_sk IS NOT NULL | ||
AND wcs_user_sk IS NOT NULL | ||
ORDER BY wcs_user_sk, tstamp_inSec | ||
ORDER BY wcs_user_sk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good change. The UDF logic does this [user_sk, timestamp] sort, but it doesn't need to be global so it's happening in the UDF get_sessions
itself.
This PR just remove
ORDER BY tstamp_inSec
as it is not necessary.