-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for pure Python wheels. #96
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me. Once this is in we'll need follow-ups in the relevant repos.
Marking as draft until I finish testing with rapidsai/cudf#15223. |
rapidsai/cudf#15223 succeeded and all looks fine. Artifacts are named without Python/arch versions if you set @vyasr Do you want to re-review? I made some substantial changes since you approved. We should be good to merge this with one review. |
/merge |
This marks `dask-cudf` as a pure wheel, meaning that the CI artifacts are not specific to a Python version or CPU architecture. This change depends on rapidsai/gha-tools#96, and makes CI workflows more robust by allowing the test matrix to be separated from the build matrix. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Jake Awe (https://github.com/AyodeAwe) URL: #15223
This marks `cuxfilter` as a pure wheel, meaning that the CI artifacts are not specific to a Python version or CPU architecture. This change depends on rapidsai/gha-tools#96, and makes CI workflows more robust by allowing the test matrix to be separated from the build matrix. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Jake Awe (https://github.com/AyodeAwe) URL: #577
## Description This marks `rapids-dask-dependency` as a pure wheel, meaning that the CI artifacts are not specific to a Python version or CPU architecture. This change depends on rapidsai/gha-tools#96, and makes CI workflows more robust by allowing the test matrix to be separated from the build matrix.
…I artifacts as pure wheels (#4216) This marks `nx-cugraph`, `cugraph-dgl`, `cugraph-pyg`, and `cugraph-equivariant` as pure wheels, meaning that the CI artifacts are not specific to a Python version or CPU architecture. This change depends on rapidsai/gha-tools#96, and makes CI workflows more robust by allowing the test matrix to be separated from the build matrix. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Ray Douglass (https://github.com/raydouglass) URL: #4216
This improves the handling of pure Python wheels in
rapids-package-name
. When dealing with pure Python packages, we don't want the Python version or CPU arch to be a part of the package's identifiers.After this is merged, we can adopt this change across RAPIDS repos for pure wheels like dask-cudf, cuxfilter, etc. and then revert rapidsai/shared-workflows#188.
List of pure packages that need to be updated: