Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ci to options for label checker categories #564

Closed
wants to merge 1 commit into from

Conversation

gforsyth
Copy link

I opened a PR over on dask-cuda and didn't see a ci label listed as an option to pass the label-checker, but it seems like it does exist.

Not sure if it's universal across RAPIDS repos, but if it is, it should be added to this page.

@gforsyth gforsyth requested a review from a team as a code owner December 13, 2024 19:39
Copy link

vercel bot commented Dec 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Dec 13, 2024 7:40pm

Copy link

netlify bot commented Dec 13, 2024

Deploy Preview for docs-rapids-ai ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit e54c6e3
🔍 Latest deploy log https://app.netlify.com/sites/docs-rapids-ai/deploys/675c8d77f356c20008c1ad43
😎 Deploy Preview https://deploy-preview-564--docs-rapids-ai.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The allowed list of labels is here: https://github.com/rapidsai/ops-bot/blob/fdeb43f78722173f39944d331ac36cff52594c61/src/plugins/LabelChecker/label_checker.ts#L61

ci is an informational label but not a permitted category, so the label checker will fail. This category information is used to generate changelogs.

Every RAPIDS library PR must be one marked with one of the listed categories, and breaking or non-breaking.

@gforsyth
Copy link
Author

Ahh, ok, thanks for clarifying. Do you think adding a ci category makes sense?

@bdice
Copy link
Contributor

bdice commented Dec 13, 2024

Ahh, ok, thanks for clarifying. Do you think adding a ci category makes sense?

Usually we just put build-related changes in “improvement.” Calling out CI changes in the changelog is probably not that useful, as it won’t affect library users directly.

@gforsyth gforsyth closed this Dec 16, 2024
@gforsyth gforsyth deleted the label-options branch December 16, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants