Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add automation for cudf-java docs #552

Merged
merged 10 commits into from
Oct 30, 2024
Merged

add automation for cudf-java docs #552

merged 10 commits into from
Oct 30, 2024

Conversation

AyodeAwe
Copy link
Contributor

@AyodeAwe AyodeAwe commented Oct 21, 2024 •
edited
Loading

  • Adds script to upload the new docs to s3
  • Adds a workflow to automate the upload and PR creation.

Tested here:

I tested (using the literate-octo-potato repository) that:

  • AWS credentials are correctly assigned through OIDC (all repos in rapidsai have access to the rapidsai-docs bucket via this line)
  • (locally) The upload_cudf_java_docs.sh script works correctly
  • The find and replace logic to enable the stable docs version for cudf-java works correctly
  • The pull request is correctly created. (e.g https://github.com/rapidsai/literate-octo-potato/pull/850)

@AyodeAwe AyodeAwe requested a review from a team as a code owner October 21, 2024 19:08
@vercel Vercel
Copy link

vercel bot commented Oct 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Oct 30, 2024 2:46pm

@AyodeAwe AyodeAwe marked this pull request as draft October 21, 2024 19:09
@netlify Netlify
Copy link

netlify bot commented Oct 21, 2024 •
edited
Loading

✅ Deploy Preview for docs-rapids-ai ready!

Name Link
🔨 Latest commit cc00b2b
🔍 Latest deploy log https://app.netlify.com/sites/docs-rapids-ai/deploys/67224681edd23d0008e85882
😎 Deploy Preview https://deploy-preview-552--docs-rapids-ai.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AyodeAwe AyodeAwe marked this pull request as ready for review October 23, 2024 16:37
@AyodeAwe AyodeAwe marked this pull request as draft October 23, 2024 16:50
@AyodeAwe AyodeAwe requested a review from raydouglass October 23, 2024 16:51
@AyodeAwe AyodeAwe marked this pull request as ready for review October 29, 2024 13:27
ajschmidt8
ajschmidt8 reviewed Oct 30, 2024
View reviewed changes
Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

left a few comments

ci/upload_cudf_java_docs.sh Outdated Show resolved Hide resolved
ci/upload_cudf_java_docs.sh Outdated Show resolved Hide resolved
@AyodeAwe
Copy link
Contributor Author

Changes were tested in this run:

https://github.com/rapidsai/literate-octo-potato/actions/runs/11595596688/job/32284584207

@AyodeAwe AyodeAwe closed this Oct 30, 2024
@AyodeAwe AyodeAwe reopened this Oct 30, 2024
@AyodeAwe AyodeAwe merged commit 47cc727 into main Oct 30, 2024
7 checks passed
@ajschmidt8 ajschmidt8 deleted the automate-cudf-java-docs branch October 30, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raydouglass raydouglass raydouglass left review comments

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AyodeAwe @raydouglass @ajschmidt8