-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repository overhaul for RAPIDS v23.08 #539
Comments
This was referenced Mar 27, 2023
Merged
Added a Breaking changes section |
This was referenced Apr 17, 2023
Merged
Note that this change is now being targeted for RAPIDS 23.08 release. |
raydouglass
changed the title
Repository overhaul for RAPIDS v23.06
Repository overhaul for RAPIDS v23.08
Jun 26, 2023
This was referenced Jul 20, 2023
Merged
raydouglass
added a commit
that referenced
this issue
Jul 25, 2023
Closes #539 This PR overhauls the `docker` according to #539. Multi-arch builds inspired from rapidsai/miniforge-cuda#31 Note: this PR merges into `branch-23.08-overhaul` instead of `branch-23.08`. `branch-23.08-overhaul` was manually created to remove the vast majority of the repo. Merging this PR into that branch shows more obvious changes instead of a [long list of deleted files](branch-23.08...branch-23.08-overhaul). To-do: - [x] Handle uploading nightlies with alpha version tag - [x] `main` builds should clean up `condarc` - [x] Add tests - [x] Test all notebooks (not just cudf) Follow up PRs: - Dockerhub/NGC readme updater - Enable nightly tests - Remove required `up-to-date` status check - Merge `branch-23.08-overhaul` into `branch-23.08` - Add style checking (#545 (comment)) Authors: - Ray Douglass (https://github.com/raydouglass)
4 tasks
Closed
This was referenced Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
docker
repo (RAPIDS end-user images) overhaulThis issue outlines how the RAPIDS end-user images in the
docker
repo will be overhauled to improve functionality and performance.Images
Requirements
These are the requirements for all images produced by this repo.
amd64
andaarch64
/arm64
images to the same docker repositorya. This eliminates the
arm64
variant repositories such as https://hub.docker.com/r/rapidsai/rapidsai-core-arm64base
conda environmentroot
user namedrapids
WORKDIR
as therapids
user's home directory${RAPIDS_VER}-cuda${CUDA_VER}-py${PYTHON_VER}
a. Nightly builds will append
a
to theRAPIDS_VER
(eg23.08a
)Considerations
dependencies.yaml
consumable bydependency-file-generator
a. If there aren't many, might be simpler to directly install them (eg
mamba install rapids ipython
)sudoers
allowing therapids
user tosudo
Base image
This image is the basic docker image that installs the RAPIDS suite of libraries.
Requirements
FROM
rapidsai/mambaforge-cuda
CMD
to launch anipython
REPLrapids
meta packagedask
/distributed
/dask-sql
nightly conda builds for nightly image buildsipython
dependencyrapidsai/base
Notebooks image
This image extends the base image to include Jupyter and RAPIDS notebooks.
Requirements
FROM
the base image define aboveCMD
to launch (in the foreground) a jupyter serverWORKDIR
rapidsai/notebooks
Implementation
Building the base and notebooks images should utilize a multi-stage docker build.
Stage 1
notebooks
directory of each RAPIDS repository and associated datasets if requiredStage 2
Stage 3
Testing
Base image
The base image will be tested using basic RAPIDS smoke tests being developed in their respective repositories. The full suite of unit tests will not be run.
Notebooks image
The notebooks image will be tested using the "notebook tests" which basically executes the notebooks provided by each repositories (consolidated in the
notebooks
repo).It will be necessary to standardize the mechanism for testing each notebook and for exempting a notebook from testing.
cugraph
provides a reliable way for doing this: https://github.com/rapidsai/cugraph/blob/branch-23.04/ci/notebook_list.py.Breaking changes
These are the breaking changes that will occur when v23.06 of this
docker
repository is released:rapidsai/rapidsai-core
is deprecated and superceded byrapidsai/base
andrapidsai/notebooks
rapidsai/rapidsai:23.02-cuda11.8-runtime-ubuntu22.04-py3.10
) are replaced by therapidsai/notebooks
docker repoIMAGE_TYPE
&LINUX_VER
will be removed from image tags. Change${RAPIDS_VER}-cuda${CUDA_VER}-${IMAGE_TYPE}-${LINUX_VER}-py${PYTHON_VER}
to${RAPIDS_VER}-cuda${CUDA_VER}-py${PYTHON_VER}
arm64
image repositories (egrapidsai/rapidsai-arm64
) are deprecated and superceded by multi-architectural images inrapidsai/base
andrapidsai/notebooks
root
user. Instead they will use non-root userrapids
a. To use previous behavior, supply
--user root
to thedocker run
commandbase
image will start anipython
REPL instead of abash
shella. To use previous behavior, supply a
docker run
CMD
ofbash
(egdocker run -it ${IMAGE} bash
)notebooks
image will startjupyter-lab
in the foreground instead of running in the background and starting abash
shell.a. To use previous behavior, supply a
docker run
CMD
ofbash
(egdocker run -it ${IMAGE} bash
) and runjupyter-lab
in the backgroundnotebooks
image will not longer contain the full source code git clone of RAPIDS repositoriesa. To use previous behavior, start the container and
git clone ${RAPIDS_GIT_URL}
for each required RAPIDS repositoryrapids
conda environment is removed and replaced by thebase
conda environmentEXTRA_APT_PACKAGES
&EXTRA_YUM_PACKAGES
will not longer be supported.LINUX_VER
will be removed from the image tags. The Ubuntu version is implied by the CUDA version./rapids/notebooks
to/home/rapids/notebooks
centos7
&rockylinux8
OSes are dropped.a. Users can manually build the images with these OSes by supplying
--build-arg LINUX_VER=centos7
, but this not tested/supportedrapidsai/base
andrapidsai-notebooks
with analpha
tag for theRAPIDS_VER
(eg23.08a
).Deprecated docker repositories
These docker repositories will be deprecated:
nightly
andarm64
repos are folded into therapidsai/base
&rapidsai/notebooks
repos. Thedev
/devel
repos are replaced by devcontainers.rapidsai/rapidsai-core
is replaced byrapidsai/base
rapidsai/rapidsai
is replaced byrapidsai/notebooks
The text was updated successfully, but these errors were encountered: