-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add UCX 1.17.0 support #338
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
added
improvement
Improves an existing functionality
non-breaking
Introduces a non-breaking change
labels
Jul 1, 2024
pentschev
reviewed
Jul 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @jameslamb !
pentschev
approved these changes
Jul 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @jameslamb .
vyasr
approved these changes
Jul 1, 2024
This was referenced Jul 30, 2024
rapids-bot bot
pushed a commit
to rapidsai/raft
that referenced
this pull request
Jul 30, 2024
Contributes to rapidsai/build-planning#77. Follow-up to rapidsai/devcontainers#338 Proposes updating the pip devcontainers to use v1.17.0, as part of an effort to use that version across RAPIDS. Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Ray Douglass (https://github.com/raydouglass) - Peter Andreas Entschev (https://github.com/pentschev) URL: #2401
rapids-bot bot
pushed a commit
to rapidsai/cuvs
that referenced
this pull request
Jul 31, 2024
Contributes to rapidsai/build-planning#77. Follow-up to rapidsai/devcontainers#338 Proposes updating the pip devcontainers to use v1.17.0, as part of an effort to use that version across RAPIDS. Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Peter Andreas Entschev (https://github.com/pentschev) - Mike Sarahan (https://github.com/msarahan) URL: #262
divyegala
pushed a commit
to divyegala/cuvs
that referenced
this pull request
Aug 7, 2024
Contributes to rapidsai/build-planning#77. Follow-up to rapidsai/devcontainers#338 Proposes updating the pip devcontainers to use v1.17.0, as part of an effort to use that version across RAPIDS. Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Peter Andreas Entschev (https://github.com/pentschev) - Mike Sarahan (https://github.com/msarahan) URL: rapidsai#262
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
contributes to rapidsai/build-planning#77
Adds support for UCX 1.17.0.
Notes for Reviewers
I'll follow this up with changes to use UCX 1.17.0 in the devcontainers for relevant RAPIDS repos (e.g. those in the list of PRs linked at #273).