Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prepend devcontainer name with the username #276

Merged
merged 1 commit into from
Apr 23, 2024
Merged

prepend devcontainer name with the username #276

merged 1 commit into from
Apr 23, 2024

Conversation

trxcllnt
Copy link
Collaborator

This is to support the users-on-a-shared-DGX workflow.

jameslamb
jameslamb approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this! Based on my experience so far using devcontainers out on a shared machine, I agree it'd help to remove this source of conflicts.

@trxcllnt trxcllnt merged commit 2297d19 into rapidsai:branch-24.06 Apr 23, 2024
24 checks passed
@trxcllnt trxcllnt deleted the fea/username-in-container-name branch April 23, 2024 21:09
@trxcllnt trxcllnt mentioned this pull request Apr 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jameslamb jameslamb jameslamb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trxcllnt @jameslamb