Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate dask/notebooks/HPO_demo.ipynb to deployment #174

Merged
merged 13 commits into from
Apr 11, 2023
Merged

Migrate dask/notebooks/HPO_demo.ipynb to deployment #174

merged 13 commits into from
Apr 11, 2023

Conversation

skirui-source
Copy link
Contributor

@skirui-source skirui-source commented Feb 28, 2023 •
edited
Loading

Fixes: #208 - This PR tracks the migration of dask_hpo_notebook to deployment docs.

See #203 (comment) for detailed migration instructions. The following changes have been made in this PR;

Tasks

  • Decide if notebook should be migrated and add "migrate: X" label (if no also close this issue)
  • Test if notebook works
  • Fix up anything that needs changing
  • Ensure notebook has good title, description and metadata tags in the first cell
  • Replace deployment instructions with links to docs pages
  • Copy notebook into a new folder into deployment docs examples
  • Copy any supporting files to the folder
  • Add notebook to examples toctree
  • Make PR to deployment docs repo

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@skirui-source skirui-source marked this pull request as ready for review March 16, 2023 07:43
@skirui-source skirui-source mentioned this pull request Mar 16, 2023
Closed
@skirui-source skirui-source marked this pull request as draft March 27, 2023 16:34
@skirui-source skirui-source marked this pull request as ready for review April 6, 2023 17:46
@skirui-source
Copy link
Contributor Author

@jacobtomlinson
I added the LocalCUDACluster docs in this PR, please take a look when you get the chance 👍🏾

@skirui-source skirui-source requested a review from jarmak-nv April 10, 2023 22:32
jacobtomlinson
jacobtomlinson approved these changes Apr 11, 2023
View reviewed changes
Copy link
Member

@jacobtomlinson jacobtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great thanks @skirui-source

@jacobtomlinson jacobtomlinson merged commit 6214a25 into main Apr 11, 2023
@jacobtomlinson jacobtomlinson deleted the migrate_hpo_demo_notebook branch April 11, 2023 16:08
@jacobtomlinson jacobtomlinson mentioned this pull request Apr 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobtomlinson jacobtomlinson jacobtomlinson approved these changes

@jarmak-nv jarmak-nv Awaiting requested review from jarmak-nv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate dask/notebooks/HPO_demo.ipynb to deployment docs
3 participants
@skirui-source @jacobtomlinson @jarmak-nv