Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove line-break that's breaking link #982

Merged
merged 1 commit into from
Aug 29, 2022

Conversation

ntabris
Copy link
Contributor

@ntabris ntabris commented Aug 29, 2022

https://docs.rapids.ai/api/dask-cuda/nightly/examples/best-practices.html currently shows

[...] don’t force and Host-to-Device/Device-to-Host transfers. See Accelerated Networking_ for more discussion

rather than the link. This should fix that.

@GPUtester
Copy link
Contributor

Can one of the admins verify this patch?

Admins can comment ok to test to allow this one PR to run or add to allowlist to allow all future PRs from the same author to run.

@pentschev
Copy link
Member

ok to test

@pentschev pentschev added 3 - Ready for Review Ready for review by team doc Documentation non-breaking Non-breaking change labels Aug 29, 2022
@quasiben
Copy link
Member

add to allowlist

@quasiben
Copy link
Member

Thanks @ntabris

@pentschev
Copy link
Member

@gpucibot merge

@codecov-commenter
Copy link

codecov-commenter commented Aug 29, 2022

Codecov Report

Base: 0.00% // Head: 0.00% // No change to project coverage 👍

Coverage data is based on head (160ca6b) compared to base (1c1fe78).
Patch has no changes to coverable lines.

Additional details and impacted files
@@              Coverage Diff              @@
##           branch-22.10    #982    +/-   ##
=============================================
  Coverage          0.00%   0.00%            
=============================================
  Files                23      16     -7     
  Lines              3100    2109   -991     
=============================================
+ Misses             3100    2109   -991     
Impacted Files Coverage Δ
dask_cuda/benchmarks/utils.py
dask_cuda/benchmarks/local_cudf_merge.py
dask_cuda/benchmarks/common.py
dask_cuda/benchmarks/local_cudf_shuffle.py
dask_cuda/_version.py
dask_cuda/benchmarks/local_cupy_map_overlap.py
dask_cuda/benchmarks/local_cupy.py

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rapids-bot rapids-bot bot merged commit 86a9846 into rapidsai:branch-22.10 Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team doc Documentation non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants