Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test memory_limit=None for CUDAWorker #946

Merged
merged 3 commits into from
Jul 5, 2022
Merged

Test memory_limit=None for CUDAWorker #946

merged 3 commits into from
Jul 5, 2022

Conversation

wence-
Copy link
Contributor

@wence- wence- commented Jul 5, 2022

This introduces a test that was a TODO in #944

@wence- wence- requested a review from a team as a code owner July 5, 2022 13:55
@github-actions github-actions bot added the python python code needed label Jul 5, 2022
@wence- wence- added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jul 5, 2022
@pentschev
Copy link
Member

The errors seem to be from Tornado deprecations.

Could you add ignore:clear_current is deprecated:DeprecationWarning:tornado to https://github.com/rapidsai/dask-cuda/blob/branch-22.08/pytest.ini#L6 ?

@wence-
Copy link
Contributor Author

wence- commented Jul 5, 2022

The errors seem to be from Tornado deprecations.

Could you add ignore:clear_current is deprecated:DeprecationWarning:tornado to https://github.com/rapidsai/dask-cuda/blob/branch-22.08/pytest.ini#L6 ?

I've added the relevant lines, I hope, but let's wonder why this failure appeared, whereas it wasn't there yesterday.

This is a deprecation warning that appeared in tornado 6.2 (tornadoweb/tornado#3097), which was released yesterday. distributed added a pin for tornado<6.2, which is what is causing this problem, yesterday (dask/distributed#6668). I guess that hasn't filtered down to the nightlies, because the failing run installed tornado==6.2.

@pentschev
Copy link
Member

it seems to me that the pin is not valid for conda nightlies. If create a new environment:

$ mamba create -n dask-tmp -c dask/label/dev -c conda-forge python=3.9 dask distributed

It picks:

  + dask               2022.6.2a220704  py_gc992f808_25      dask/label/dev/noarch        5kB
  + dask-core          2022.6.2a220701  py_g1a760229f_8      dask/label/dev/noarch      859kB
  + distributed        2022.6.2a220704  py_gc992f808_25      dask/label/dev/noarch      759kB
...
  + tornado                        6.2  py39hb9d737c_0       conda-forge/linux-64       673kB

In any case, if ignoring the warnings suffices for u, I wouldn't worry too much about it, as Dask will eventually resolve the problem and support tornado>=6.2, which is only an indirect dependency to Dask-CUDA. FYI, we catch DeprecationWarnings primarily to be alerted about Dask/Distributed warnings.

@pentschev
Copy link
Member

In any case I went ahead and attempted to fix the conda package as well in dask/distributed#6675, so we may be able to remove the DeprecationWarning entry once that's merged.

@wence-
pytest: Can't filter tornado deprecation warnings by module
3bdc8fe 
The warnings are emitted with stacklevel=2, which means that the
module that filterwarnings sees is the module of the caller of the
deprecated function.
@wence-
Copy link
Contributor Author

wence- commented Jul 5, 2022

Can't filter on tornado specifically, but hopefully this one will pass.

pentschev
pentschev approved these changes Jul 5, 2022
View reviewed changes
Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @wence- .

@pentschev
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit ab1088e into rapidsai:branch-22.08 Jul 5, 2022
@wence- wence- deleted the wence/fix/test-944 branch July 5, 2022 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pentschev pentschev pentschev approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python python code needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wence- @pentschev