Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmarks: Record total number of workers in dataframe #945

Merged
merged 1 commit into from
Jul 4, 2022
Merged

benchmarks: Record total number of workers in dataframe #945

merged 1 commit into from
Jul 4, 2022

Conversation

wence-
Copy link
Contributor

@wence- wence- commented Jul 4, 2022

I realise I missed this property when doing some data analysis

@wence- wence- added 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels Jul 4, 2022
@wence- wence- requested a review from a team as a code owner July 4, 2022 16:16
@github-actions github-actions bot added the python python code needed label Jul 4, 2022
@wence- wence- added the improvement Improvement / enhancement to an existing function label Jul 4, 2022
pentschev
pentschev approved these changes Jul 4, 2022
View reviewed changes
Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @wence- .

@pentschev
Copy link
Member

@gpucibot merge

@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.08@8dba7d1). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head b1ddd5b differs from pull request most recent head e576919. Consider uploading reports for the commit e576919 to get more accurate results

@@              Coverage Diff               @@
##             branch-22.08    #945   +/-   ##
==============================================
  Coverage                ?   0.00%           
==============================================
  Files                   ?      16           
  Lines                   ?    2105           
  Branches                ?       0           
==============================================
  Hits                    ?       0           
  Misses                  ?    2105           
  Partials                ?       0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dba7d1...e576919. Read the comment docs.

@rapids-bot rapids-bot bot merged commit b30eb09 into rapidsai:branch-22.08 Jul 4, 2022
@wence- wence- deleted the wence/fix/num-gpus-in-benchmark-data branch July 5, 2022 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pentschev pentschev pentschev approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python python code needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wence- @pentschev @codecov-commenter