Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add util functions to simplify printing benchmarks results #937

Merged

Conversation

pentschev
Copy link
Member

Two new utility functions are added to print benchmarks results to avoid the need to rearrange number of individual white spaces or separator lengths any time a new longer row is added, also preventing the count of spaces given indentation of code.

Two new utility functions are added to print benchmarks results to avoid
the need to rearrange number of individual white spaces or separator
lengths any time a new longer row is added, also preventing the count of
spaces given indentation of code.
@pentschev pentschev requested a review from a team as a code owner June 22, 2022 12:31
@github-actions github-actions bot added the python python code needed label Jun 22, 2022
@pentschev pentschev added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change and removed python python code needed labels Jun 22, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 22, 2022

Codecov Report

Merging #937 (0ea26db) into branch-22.08 (c89f0db) will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           branch-22.08    #937    +/-   ##
=============================================
  Coverage          0.00%   0.00%            
=============================================
  Files                22      16     -6     
  Lines              3073    2092   -981     
=============================================
+ Misses             3073    2092   -981     
Impacted Files Coverage Δ
dask_cuda/benchmarks/local_cudf_merge.py
dask_cuda/benchmarks/local_cudf_shuffle.py
dask_cuda/benchmarks/local_cupy.py
dask_cuda/benchmarks/local_cupy_map_overlap.py
dask_cuda/benchmarks/utils.py
dask_cuda/_version.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c89f0db...0ea26db. Read the comment docs.

Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these look fine.

@quasiben
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit a2e3223 into rapidsai:branch-22.08 Jun 23, 2022
@pentschev pentschev deleted the improve-benchmark-formatting branch June 23, 2022 17:07
rapids-bot bot pushed a commit that referenced this pull request Jun 24, 2022
The existing throughput would only give an overview of total data processed for the complete workflow, but no insight on communications which the new bandwidth value now does. Additionally, moved common peer-to-peer bandwidth computation as utility function.

Depends on #937

Authors:
  - Peter Andreas Entschev (https://github.com/pentschev)

Approvers:
  - Lawrence Mitchell (https://github.com/wence-)
  - Benjamin Zaitlen (https://github.com/quasiben)

URL: #938
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants