Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove click pinning #932

Merged
merged 2 commits into from
Jun 15, 2022
Merged

Remove click pinning #932

merged 2 commits into from
Jun 15, 2022

Conversation

charlesbluca
Copy link
Member

With the click breakage in Distributed presumably resolved, we should be good removing this click pinning.

Closes #931

@charlesbluca charlesbluca added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 13, 2022
@charlesbluca charlesbluca mentioned this pull request Jun 13, 2022
Closed
pentschev
pentschev approved these changes Jun 13, 2022
View reviewed changes
Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @charlesbluca .

@charlesbluca
Copy link
Member Author

Looks like the failures here are unrelated, and caused by issues with the gpuCI runner's CUDA driver installation?

@pentschev
Copy link
Member

Yes, looks like a CI issue

@pentschev
Copy link
Member

rerun tests

@jakirkham
Copy link
Member

Suspect this CI issue is related to some other ones we have run into with CUDA Python not finding libcuda.so

cc @galipremsagar (for awareness)

@galipremsagar
Copy link
Contributor

galipremsagar commented Jun 13, 2022 •
edited
Loading

Suspect this CI issue is related to some other ones we have run into with CUDA Python not finding libcuda.so

cc @galipremsagar (for awareness)

Yes, all of Rapids CI is currently blocked on rapidsai/cudf#11058.

@galipremsagar
Copy link
Contributor

rerun tests

@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.08@f93a023). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             branch-22.08    #932   +/-   ##
==============================================
  Coverage                ?   0.00%           
==============================================
  Files                   ?      16           
  Lines                   ?    2094           
  Branches                ?       0           
==============================================
  Hits                    ?       0           
  Misses                  ?    2094           
  Partials                ?       0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f93a023...b2dc703. Read the comment docs.

@galipremsagar
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 7d12e82 into rapidsai:branch-22.08 Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pentschev pentschev pentschev approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Overly precise click==8.0.4 pin?
5 participants
@charlesbluca @pentschev @jakirkham @galipremsagar @codecov-commenter