Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Unpin dask & distributed for development #927

Merged
merged 2 commits into from
Jun 16, 2022
Merged

[REVIEW] Unpin dask & distributed for development #927

merged 2 commits into from
Jun 16, 2022

Conversation

galipremsagar
Copy link
Contributor

Changes to be in line with: rapidsai/cudf#11058

@galipremsagar galipremsagar added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 6, 2022
@galipremsagar galipremsagar self-assigned this Jun 6, 2022
@galipremsagar galipremsagar requested a review from a team as a code owner June 6, 2022 19:17
@github-actions github-actions bot added the gpuCI gpuCI issue label Jun 6, 2022
pentschev
pentschev requested changes Jun 6, 2022
View reviewed changes
ci/gpu/build.sh Outdated Show resolved Hide resolved
pentschev
pentschev approved these changes Jun 7, 2022
View reviewed changes
Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for taking care of this as usual @galipremsagar !

@pentschev
Copy link
Member

rerun tests

2 similar comments
@galipremsagar
Copy link
Contributor Author

rerun tests

@galipremsagar
Copy link
Contributor Author

rerun tests

@pentschev
Copy link
Member

Failing tests were fixed by #934 .

rerun tests

@codecov-commenter
Copy link

codecov-commenter commented Jun 16, 2022 •
edited
Loading

Codecov Report

Merging #927 (450be43) into branch-22.08 (e2ff3d7) will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           branch-22.08    #927    +/-   ##
=============================================
  Coverage          0.00%   0.00%            
=============================================
  Files                22      16     -6     
  Lines              3075    2092   -983     
=============================================
+ Misses             3075    2092   -983
Impacted Files Coverage Δ
dask_cuda/cuda_worker.py 0.00% <0.00%> (ø)
dask_cuda/_version.py
dask_cuda/benchmarks/local_cudf_shuffle.py
dask_cuda/benchmarks/utils.py
dask_cuda/benchmarks/local_cudf_merge.py
dask_cuda/benchmarks/local_cupy.py
dask_cuda/benchmarks/local_cupy_map_overlap.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2ff3d7...450be43. Read the comment docs.

@pentschev
Copy link
Member

Thanks @galipremsagar !

@gpucibot merge

@pentschev
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit c89f0db into rapidsai:branch-22.08 Jun 16, 2022
@jakirkham
Copy link
Member

Thanks Prem for the PR and Peter for shepherding it through! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

@pentschev pentschev pentschev approved these changes

Assignees

@galipremsagar galipremsagar

Labels
gpuCI gpuCI issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@galipremsagar @pentschev @codecov-commenter @jakirkham @ajschmidt8