Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xfail mark to test_pre_import_not_found #908

Merged

Conversation

pentschev
Copy link
Member

Xfailing the test is needed for now due to dask/distributed#6320 . This should not have any major impact unless the user specifies a module that cannot be imported via --pre-import, in which case the worker process will hang indefinitely.

@pentschev pentschev requested a review from a team as a code owner May 12, 2022 19:51
@github-actions github-actions bot added the python python code needed label May 12, 2022
@pentschev pentschev added bug Something isn't working 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels May 12, 2022
@jakirkham
Copy link
Member

Thanks Peter! 🙏

@pentschev
Copy link
Member Author

Thanks @jakirkham for approving!

@pentschev
Copy link
Member Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 8e019c3 into rapidsai:branch-22.06 May 12, 2022
@pentschev pentschev deleted the xfail-test_pre_import_not_found branch June 23, 2022 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Non-breaking change python python code needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants