Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use upstream warning functions for CUDA initialization #894

Merged

Conversation

charlesbluca
Copy link
Member

Following up on dask/distributed#6121, this PR uses Distributed's warning functions for CUDA initialization, cutting down on code duplication.

cc @pentschev

@charlesbluca charlesbluca added python python code needed 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels Apr 14, 2022
@charlesbluca charlesbluca requested a review from a team as a code owner April 14, 2022 14:23
@charlesbluca charlesbluca added the doc Documentation label Apr 14, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 14, 2022

Codecov Report

Merging #894 (2b2a48d) into branch-22.06 (952e130) will increase coverage by 24.47%.
The diff coverage is 0.00%.

❗ Current head 2b2a48d differs from pull request most recent head 062d3d4. Consider uploading reports for the commit 062d3d4 to get more accurate results

@@                Coverage Diff                @@
##           branch-22.06     #894       +/-   ##
=================================================
+ Coverage         65.01%   89.49%   +24.47%     
=================================================
  Files                22       16        -6     
  Lines              3076     2094      -982     
=================================================
- Hits               2000     1874      -126     
+ Misses             1076      220      -856     
Impacted Files Coverage Δ
dask_cuda/initialize.py 87.23% <0.00%> (-0.27%) ⬇️
dask_cuda/benchmarks/local_cupy_map_overlap.py
dask_cuda/benchmarks/local_cudf_merge.py
dask_cuda/benchmarks/local_cudf_shuffle.py
dask_cuda/benchmarks/local_cupy.py
dask_cuda/benchmarks/utils.py
dask_cuda/_version.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 952e130...062d3d4. Read the comment docs.

Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @charlesbluca .

@pentschev
Copy link
Member

rerun tests

@pentschev
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 7a0c2c2 into rapidsai:branch-22.06 Apr 15, 2022
@jakirkham
Copy link
Member

Also PR ( dask/distributed#6121 ) is part of the (currently in progress) 2022.4.1 distributed release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team doc Documentation non-breaking Non-breaking change python python code needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants