Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix skipping GDS test if cucim is not installed #813

Merged
merged 3 commits into from
Dec 3, 2021
Merged

Fix skipping GDS test if cucim is not installed #813

merged 3 commits into from
Dec 3, 2021

Conversation

pentschev
Copy link
Member

When ProxifyHostFile.register_disk_spilling() is configured with gds=True an ImportError is raised and the test fails. To fix that we force enabling cucim (if available) after disk spilling is configured, or skip the test if cucim is unavailable.

@pentschev pentschev requested a review from a team as a code owner November 25, 2021 15:44
@github-actions github-actions bot added the python python code needed label Nov 25, 2021
@pentschev pentschev requested a review from madsbk November 25, 2021 15:46
@pentschev pentschev added 3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Non-breaking change labels Nov 25, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.02@f1b0e27). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-22.02     #813   +/-   ##
===============================================
  Coverage                ?   89.15%           
===============================================
  Files                   ?       16           
  Lines                   ?     2057           
  Branches                ?        0           
===============================================
  Hits                    ?     1834           
  Misses                  ?      223           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1b0e27...a54d6d0. Read the comment docs.

madsbk
madsbk requested changes Nov 30, 2021
View reviewed changes
Copy link
Member

@madsbk madsbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only have a minor rewording.

dask_cuda/tests/test_gds.py Outdated Show resolved Hide resolved
@pentschev @madsbk
Improve test_gds comment phrasing
a54d6d0 
Co-authored-by: Mads R. B. Kristensen <[email protected]>
@pentschev
Copy link
Member Author

@madsbk could you approve if there are no other changes to be done?

@jakirkham jakirkham requested a review from madsbk December 3, 2021 00:33
@madsbk
Copy link
Member

madsbk commented Dec 3, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 2e9a429 into rapidsai:branch-22.02 Dec 3, 2021
@pentschev
Copy link
Member Author

Thanks @madsbk !

@pentschev pentschev deleted the skip-cucim-test branch January 14, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madsbk madsbk madsbk approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Non-breaking change python python code needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pentschev @codecov-commenter @madsbk