Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging when RMM allocation fails #782

Merged
merged 2 commits into from
Nov 15, 2021
Merged

Logging when RMM allocation fails #782

merged 2 commits into from
Nov 15, 2021

Conversation

madsbk
Copy link
Member

@madsbk madsbk commented Nov 15, 2021 •
edited
Loading

Dask Workers now logs some more information when spilling-on-demand fails.

cc. @randerzander @VibhuJawa

@madsbk madsbk added 2 - In Progress Currently a work in progress improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 15, 2021
@github-actions github-actions bot added the python python code needed label Nov 15, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.12@7f24209). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.12     #782   +/-   ##
===============================================
  Coverage                ?   90.03%           
===============================================
  Files                   ?       15           
  Lines                   ?     1987           
  Branches                ?        0           
===============================================
  Hits                    ?     1789           
  Misses                  ?      198           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f24209...d6ed9ab. Read the comment docs.

@rapidsai rapidsai deleted a comment from pentschev Nov 15, 2021
@madsbk madsbk force-pushed the on_demand_spilling_logging branch from 1501b42 to bce4992 Compare November 15, 2021 13:04
@madsbk madsbk added 4 - Needs Reviewer Waiting for reviewer to review or respond and removed 2 - In Progress Currently a work in progress labels Nov 15, 2021
@madsbk madsbk marked this pull request as ready for review November 15, 2021 13:08
@madsbk madsbk requested a review from a team as a code owner November 15, 2021 13:08
@madsbk madsbk force-pushed the on_demand_spilling_logging branch from bce4992 to 19c63bc Compare November 15, 2021 13:09
@madsbk madsbk added the 3 - Ready for Review Ready for review by team label Nov 15, 2021
pentschev
pentschev approved these changes Nov 15, 2021
View reviewed changes
Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change request of an unnecessary line in the test, otherwise LGTM. Thanks @madsbk .

dask_cuda/tests/test_proxify_host_file.py Outdated Show resolved Hide resolved
@madsbk @pentschev
Clean up
d6ed9ab 
Co-authored-by: Peter Andreas Entschev <[email protected]>
@madsbk
Copy link
Member Author

madsbk commented Nov 15, 2021

Minor change request of an unnecessary line in the test, otherwise LGTM. Thanks @madsbk .

Thanks @pentschev

@pentschev
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 731548c into rapidsai:branch-21.12 Nov 15, 2021
@madsbk madsbk deleted the on_demand_spilling_logging branch November 15, 2021 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pentschev pentschev pentschev approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team 4 - Needs Reviewer Waiting for reviewer to review or respond improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python python code needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@madsbk @codecov-commenter @pentschev