Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test of sizeof proxy object #774

Merged
merged 2 commits into from
Nov 11, 2021

Conversation

madsbk
Copy link
Member

@madsbk madsbk commented Nov 11, 2021

Adding test of sizeof of ProxyObject motivated by rapidsai/cudf#9544, which change the __sizeof__ semantic of cudf.
As far as I can see, ProxyObject should continue working after rapidsai/cudf#9544 has been merged.

@github-actions github-actions bot added the python python code needed label Nov 11, 2021
@madsbk madsbk added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 11, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 11, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.12@b659475). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head c8fa519 differs from pull request most recent head 8c288b5. Consider uploading reports for the commit 8c288b5 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.12     #774   +/-   ##
===============================================
  Coverage                ?   89.33%           
===============================================
  Files                   ?       15           
  Lines                   ?     1969           
  Branches                ?        0           
===============================================
  Hits                    ?     1759           
  Misses                  ?      210           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b659475...8c288b5. Read the comment docs.

@madsbk madsbk marked this pull request as ready for review November 11, 2021 09:25
@madsbk madsbk requested a review from a team as a code owner November 11, 2021 09:25
@madsbk madsbk added the 3 - Ready for Review Ready for review by team label Nov 11, 2021
@quasiben
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 5136835 into rapidsai:branch-21.12 Nov 11, 2021
@madsbk madsbk deleted the sizeof_proxy_object branch November 12, 2021 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python python code needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants