Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify JIT-unspill and writing docs #768

Merged
merged 6 commits into from
Nov 2, 2021
Merged

Simplify JIT-unspill and writing docs #768

merged 6 commits into from
Nov 2, 2021

Conversation

madsbk
Copy link
Member

@madsbk madsbk commented Oct 29, 2021 •
edited
Loading

Simplify and clean up of JIT-unspill. Particularly, the evict functions are now sharing common code.
Also adding function docs.

@github-actions github-actions bot added the python python code needed label Oct 29, 2021
@madsbk madsbk added 2 - In Progress Currently a work in progress improvement Improvement / enhancement to an existing function non-breaking Non-breaking change and removed python python code needed labels Oct 29, 2021
@madsbk madsbk changed the title [WIP] Simplify of JIT-unspill [WIP] Simplify JIT-unspill Oct 29, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.12@b52d1d6). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head eb0ad5f differs from pull request most recent head 69eac03. Consider uploading reports for the commit 69eac03 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.12     #768   +/-   ##
===============================================
  Coverage                ?   79.86%           
===============================================
  Files                   ?       15           
  Lines                   ?     1962           
  Branches                ?        0           
===============================================
  Hits                    ?     1567           
  Misses                  ?      395           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b52d1d6...69eac03. Read the comment docs.

@madsbk madsbk changed the title [WIP] Simplify JIT-unspill [WIP] Simplify JIT-unspill and adding docs Oct 29, 2021
@madsbk madsbk changed the title [WIP] Simplify JIT-unspill and adding docs [WIP] Simplify JIT-unspill and writing docs Oct 29, 2021
@github-actions github-actions bot added the python python code needed label Oct 29, 2021
@madsbk madsbk marked this pull request as ready for review November 1, 2021 14:44
@madsbk madsbk requested a review from a team as a code owner November 1, 2021 14:44
@madsbk madsbk changed the title [WIP] Simplify JIT-unspill and writing docs Simplify JIT-unspill and writing docs Nov 1, 2021
@madsbk madsbk added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Nov 1, 2021
pentschev
pentschev approved these changes Nov 1, 2021
View reviewed changes
Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @madsbk . I added one suggestion on the default eviction size if you think that's appropriate, otherwise it's good to merge as is. Thanks for the work here!

dask_cuda/proxify_host_file.py Outdated Show resolved Hide resolved
@madsbk
Copy link
Member Author

madsbk commented Nov 2, 2021

Thanks @pentschev

@madsbk
Copy link
Member Author

madsbk commented Nov 2, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 984263c into rapidsai:branch-21.12 Nov 2, 2021
@madsbk madsbk deleted the cleanup_evict branch November 2, 2021 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pentschev pentschev pentschev approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python python code needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@madsbk @codecov-commenter @pentschev