-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update test_spill to use cuDF's memory_usage() #767
Update test_spill to use cuDF's memory_usage() #767
Conversation
rerun tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @pentschev
rerun tests |
2 similar comments
rerun tests |
rerun tests |
…cudf-memory_usage
Tests are still failing because gpuCI isn't picking latest dask-cudf packages, waiting for that to be resolved. |
rerun tests |
1 similar comment
rerun tests |
I wasted far too much time figuring this out. To summarize, the problem is gpuCI installs If anybody knows why this happens or has ideas to fix, please let me know, otherwise I'll merge it as is in 24 hours provided tests pass. |
Actually, this is supposed to be merged before the release, so it has to be merged by EOD today. |
Great debugging work @pentschev, thanks! |
With the cuDF move from using
__sizeof__()
tomemory_usage()
we need to update spilling tests to check against the new method. Requires rapidsai/cudf#9544 .Together with this change we fix #79 too.