Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid creating CUDA context in LocalCUDACluster parent process #765

Merged
merged 1 commit into from
Oct 28, 2021
Merged

Avoid creating CUDA context in LocalCUDACluster parent process #765

merged 1 commit into from
Oct 28, 2021

Conversation

pentschev
Copy link
Member

This is helpful for preventing an extra, unnecessary, CUDA context. However, this is only helpful if Client is not created in the same process as LocalCUDACluster, as otherwise it will anyway create a CUDA context.

@pentschev pentschev requested a review from a team as a code owner October 27, 2021 19:19
@github-actions github-actions bot added the python python code needed label Oct 27, 2021
@pentschev pentschev added 3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Non-breaking change labels Oct 27, 2021
madsbk
madsbk approved these changes Oct 28, 2021
View reviewed changes
Copy link
Member

@madsbk madsbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pentschev
Copy link
Member Author

Thanks for the review @madsbk !

@pentschev
Copy link
Member Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 1d547a0 into rapidsai:branch-21.12 Oct 28, 2021
@pentschev pentschev deleted the avoid-parent-local-cuda-cluster-context branch November 2, 2021 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madsbk madsbk madsbk approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Non-breaking change python python code needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pentschev @madsbk