Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore known but expected test warnings #759

Merged
merged 1 commit into from
Oct 22, 2021

Conversation

pentschev
Copy link
Member

Some warnings get raised during tests, they are known, expected and harmless, so it's safe to filter them out.

@pentschev pentschev requested a review from a team as a code owner October 22, 2021 18:20
@github-actions github-actions bot added the python python code needed label Oct 22, 2021
@pentschev pentschev added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change and removed python python code needed labels Oct 22, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.12@e9a291a). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.12     #759   +/-   ##
===============================================
  Coverage                ?   80.05%           
===============================================
  Files                   ?       15           
  Lines                   ?     1975           
  Branches                ?        0           
===============================================
  Hits                    ?     1581           
  Misses                  ?      394           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9a291a...16399cf. Read the comment docs.

@jakirkham
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 0478adf into rapidsai:branch-21.12 Oct 22, 2021
@jakirkham
Copy link
Member

Thanks Peter! 😄

@pentschev
Copy link
Member Author

Thanks John for the review!

@pentschev pentschev deleted the ignore-test-warnings branch November 2, 2021 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants