Removing the FrameProxyObject workaround

[madsbk]

Adding testing of cudf dataframe copy, which fails prior to rapidsai/cudf#9397

UPDATE: This PR now handles the jit-unspill failures we have been seeing with cudf v21.12.

Some background, when we introduced ProxyObject, cudf was using cudf._lib.table.Table as the base class for all frame-like objects (dataframes, series, etc). Table was implemented in cython so our proxy object had to derive from Table in order to support cython functions. The result was to use the class FrameProxyObject as a workaround:

    # In order to support the cuDF API implemented in Cython, we inherit from
    # `cudf._lib.table.Table`, which is the base class of Index, Series, and
    # Dataframes in cuDF.
    # Notice, the order of base classes matters. Since ProxyObject is the first
    # base class, ProxyObject.__init__() is called on creation, which doesn't
    # define the Table._data and Table._index attributes. Thus, accessing
    # FrameProxyObject._data and FrameProxyObject._index is pass-through to
    # ProxyObejct.__getattr__(), which is what we want.
    class FrameProxyObject(ProxyObject, cudf._lib.table.Table):
        pass

Now that cudf uses Frame, a pure Python class, we don't need this workaround anymore. In fact, using FrameProxyObject triggers some infinite recursion errors when used together with v21.12+

cc. @randerzander

[pentschev]

LGTM, thanks @madsbk !

[pentschev]

Actually the failure is legit @madsbk , seems like it's an infinite recursion.

[madsbk]

Actually the failure is legit @madsbk , seems like it's an infinite recursion.

Yes, that is because rapidsai/cudf#9397 hasn't been merged yet.

[madsbk]

I will work a bit more on this PR, maybe we can remove the need of the FrameProxyObject completely.

[codecov-commenter]

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.12@7a426e8). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             branch-21.12     #751   +/-   ##
===============================================
  Coverage                ?   62.93%           
===============================================
  Files                   ?       21           
  Lines                   ?     2898           
  Branches                ?        0           
===============================================
  Hits                    ?     1824           
  Misses                  ?     1074           
  Partials                ?        0           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a426e8...f3d7604. Read the comment docs.

[pentschev]

centos7 in queue for over 4 hours.

rerun tests

[pentschev]

rerun tests

[pentschev]

rerun tests

[pentschev]

Seems like the errors are waiting for dask/distributed#5380 to be merged.

[pentschev]

rerun tests

[madsbk]

@gpucibot merge