Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implements a ProxyManagerDummy for convenience #733

Merged
merged 1 commit into from
Sep 23, 2021
Merged

Implements a ProxyManagerDummy for convenience #733

merged 1 commit into from
Sep 23, 2021

Conversation

madsbk
Copy link
Member

@madsbk madsbk commented Sep 23, 2021

No description provided.

@github-actions github-actions bot added the python python code needed label Sep 23, 2021
@madsbk madsbk added 2 - In Progress Currently a work in progress improvement Improvement / enhancement to an existing function non-breaking Non-breaking change and removed python python code needed labels Sep 23, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2021 •
edited
Loading

Codecov Report

Merging #733 (bfb04be) into branch-21.10 (8e6ab70) will decrease coverage by 24.73%.
The diff coverage is 82.84%.

Impacted file tree graph

@@                Coverage Diff                @@
##           branch-21.10     #733       +/-   ##
=================================================
- Coverage         87.63%   62.90%   -24.74%     
=================================================
  Files                15       21        +6     
  Lines              1658     2895     +1237     
=================================================
+ Hits               1453     1821      +368     
- Misses              205     1074      +869
Impacted Files Coverage Δ
dask_cuda/benchmarks/local_cudf_merge.py 0.00% <0.00%> (ø)
dask_cuda/benchmarks/local_cudf_shuffle.py 0.00% <0.00%> (ø)
dask_cuda/benchmarks/local_cupy.py 0.00% <0.00%> (ø)
dask_cuda/benchmarks/local_cupy_map_overlap.py 0.00% <0.00%> (ø)
dask_cuda/benchmarks/utils.py 0.00% <0.00%> (ø)
dask_cuda/cuda_worker.py 77.64% <ø> (ø)
dask_cuda/get_device_memory_objects.py 90.00% <0.00%> (+21.94%) ⬆️
dask_cuda/utils.py 81.49% <60.52%> (-5.78%) ⬇️
dask_cuda/local_cuda_cluster.py 78.30% <80.00%> (+0.41%) ⬆️
dask_cuda/proxify_device_objects.py 95.45% <80.00%> (+6.56%) ⬆️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a38d0b8...bfb04be. Read the comment docs.

@madsbk madsbk marked this pull request as ready for review September 23, 2021 14:15
@madsbk madsbk requested a review from a team as a code owner September 23, 2021 14:15
@madsbk madsbk added 4 - Needs Reviewer Waiting for reviewer to review or respond and removed 2 - In Progress Currently a work in progress labels Sep 23, 2021
pentschev
pentschev approved these changes Sep 23, 2021
View reviewed changes
Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @madsbk .

@pentschev
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 28ce427 into rapidsai:branch-21.10 Sep 23, 2021
@madsbk madsbk deleted the proxy_manager_dummy branch September 24, 2021 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pentschev pentschev pentschev approved these changes

Assignees
No one assigned
Labels
4 - Needs Reviewer Waiting for reviewer to review or respond improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@madsbk @codecov-commenter @pentschev