-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add __array_ufunc__
support for ProxyObject
#731
Conversation
__array_ufunc__
support for ProxyObject
I also don't have the permissions to set the labels on this PR, can someone add them? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @galipremsagar, thanks for the fix. I only have a minor suggestion.
Codecov Report
@@ Coverage Diff @@
## branch-21.10 #731 +/- ##
=================================================
- Coverage 87.63% 61.04% -26.59%
=================================================
Files 15 21 +6
Lines 1658 2734 +1076
=================================================
+ Hits 1453 1669 +216
- Misses 205 1065 +860
Continue to review full report at Codecov.
|
@gpucibot merge |
Fixes: #730
This PR add
__array_ufunc__
toProxyObject