Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add __array_ufunc__ support for ProxyObject #731

Merged
merged 5 commits into from
Sep 21, 2021

Conversation

galipremsagar
Copy link
Contributor

Fixes: #730

This PR add __array_ufunc__ to ProxyObject

@galipremsagar galipremsagar requested a review from a team as a code owner September 21, 2021 16:51
@github-actions github-actions bot added the python python code needed label Sep 21, 2021
@galipremsagar galipremsagar changed the title add __array_ufunc__ to ProxyObject Add __array_ufunc__ support for ProxyObject Sep 21, 2021
@pentschev pentschev requested a review from madsbk September 21, 2021 17:04
@galipremsagar
Copy link
Contributor Author

I also don't have the permissions to set the labels on this PR, can someone add them?

@madsbk madsbk added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Sep 21, 2021
Copy link
Member

@madsbk madsbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @galipremsagar, thanks for the fix. I only have a minor suggestion.

dask_cuda/proxy_object.py Show resolved Hide resolved
dask_cuda/proxy_object.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #731 (1398453) into branch-21.10 (8e6ab70) will decrease coverage by 26.58%.
The diff coverage is 76.36%.

❗ Current head 1398453 differs from pull request most recent head 7cea00f. Consider uploading reports for the commit 7cea00f to get more accurate results
Impacted file tree graph

@@                Coverage Diff                @@
##           branch-21.10     #731       +/-   ##
=================================================
- Coverage         87.63%   61.04%   -26.59%     
=================================================
  Files                15       21        +6     
  Lines              1658     2734     +1076     
=================================================
+ Hits               1453     1669      +216     
- Misses              205     1065      +860     
Impacted Files Coverage Δ
dask_cuda/benchmarks/local_cudf_merge.py 0.00% <0.00%> (ø)
dask_cuda/benchmarks/local_cudf_shuffle.py 0.00% <0.00%> (ø)
dask_cuda/benchmarks/local_cupy.py 0.00% <0.00%> (ø)
dask_cuda/benchmarks/local_cupy_map_overlap.py 0.00% <0.00%> (ø)
dask_cuda/benchmarks/utils.py 0.00% <0.00%> (ø)
dask_cuda/cuda_worker.py 77.64% <ø> (ø)
dask_cuda/get_device_memory_objects.py 90.00% <0.00%> (+21.94%) ⬆️
dask_cuda/local_cuda_cluster.py 77.88% <50.00%> (ø)
dask_cuda/utils.py 81.74% <65.95%> (-5.53%) ⬇️
dask_cuda/proxify_device_objects.py 95.45% <80.00%> (+6.56%) ⬆️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a884233...7cea00f. Read the comment docs.

@madsbk
Copy link
Member

madsbk commented Sep 21, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 859c86d into rapidsai:branch-21.10 Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python python code needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implicit array conversion is happening when numpy array ufuncs are being triggered on ProxyObject's
3 participants