-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check if CUDA context was created in distributed.comm.ucx #722
Merged
rapids-bot
merged 6 commits into
rapidsai:branch-21.10
from
pentschev:check-distributed-context-creation
Sep 14, 2021
Merged
Check if CUDA context was created in distributed.comm.ucx #722
rapids-bot
merged 6 commits into
rapidsai:branch-21.10
from
pentschev:check-distributed-context-creation
Sep 14, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pentschev
added
3 - Ready for Review
Ready for review by team
bug
Something isn't working
non-breaking
Non-breaking change
labels
Sep 10, 2021
pentschev
changed the title
Check distributed context creation
Check if CUDA context was created in distributed.comm.ucx
Sep 10, 2021
rerun tests |
jakirkham
approved these changes
Sep 13, 2021
Codecov Report
@@ Coverage Diff @@
## branch-21.10 #722 +/- ##
================================================
+ Coverage 87.63% 88.65% +1.02%
================================================
Files 15 15
Lines 1658 1737 +79
================================================
+ Hits 1453 1540 +87
+ Misses 205 197 -8
Continue to review full report at Codecov.
|
rerun tests |
@gpucibot merge |
Thanks @jakirkham for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3 - Ready for Review
Ready for review by team
bug
Something isn't working
non-breaking
Non-breaking change
python
python code needed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because communications in
Nanny
are initialized before Dask preload plugins, and UCX creates the context directly within its own initializer in Distributed, Dask-CUDA will always think the CUDA context has already been incorrectly initialized when using UCX, which isn't true, with the globals added here Dask-CUDA can verify the CUDA contexts are indeed valid.Depends on dask/distributed#5308 .
Fixes #721 .