-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn if CUDA context is created on incorrect device with LocalCUDACluster
#719
Warn if CUDA context is created on incorrect device with LocalCUDACluster
#719
Conversation
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-21.10 #719 +/- ##
================================================
+ Coverage 87.63% 89.10% +1.46%
================================================
Files 15 15
Lines 1658 1734 +76
================================================
+ Hits 1453 1545 +92
+ Misses 205 189 -16
Continue to review full report at Codecov.
|
rerun tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (only a minor typo), thanks @pentschev
Co-authored-by: Mads R. B. Kristensen <[email protected]>
@gpucibot merge |
Thanks Peter for the PR and Mads for the review! 😄 |
Warns if for some reason the creation of CUDA context has already happened or occurs on the incorrect device in
LocalCUDACluster
. This can be a problem if something initializes the CUDA runtime library too early.Because these things are related to the global Python context, it's difficult to test it with pytest. But below is a reproducer for both warnings:
gpu_assignment.py
create_context.py
Fixes #384