-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] Register percentile_lookup
for FrameProxyObject
#716
Conversation
Thanks for doing this @galipremsagar ! This looks good to me but it would be good to get @madsbk thoughts when he is back on Monday |
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-21.10 #716 +/- ##
================================================
+ Coverage 87.63% 89.43% +1.80%
================================================
Files 15 15
Lines 1658 1704 +46
================================================
+ Hits 1453 1524 +71
+ Misses 205 180 -25
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @galipremsagar!
Co-authored-by: Mads R. B. Kristensen <[email protected]>
@gpucibot merge |
Thanks @galipremsagar ! |
Fixes: #714
This PR registers
percentile_lookup
forFrameProxyObject