Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Register percentile_lookup for FrameProxyObject #716

Merged
merged 6 commits into from
Sep 8, 2021

Conversation

galipremsagar
Copy link
Contributor

Fixes: #714

This PR registers percentile_lookup for FrameProxyObject

@galipremsagar galipremsagar requested a review from a team as a code owner September 1, 2021 16:51
@github-actions github-actions bot added the python python code needed label Sep 1, 2021
@quasiben quasiben added the 3 - Ready for Review Ready for review by team label Sep 2, 2021
@quasiben
Copy link
Member

quasiben commented Sep 2, 2021

Thanks for doing this @galipremsagar ! This looks good to me but it would be good to get @madsbk thoughts when he is back on Monday

@quasiben
Copy link
Member

quasiben commented Sep 2, 2021

rerun tests

@quasiben quasiben added non-breaking Non-breaking change bug Something isn't working labels Sep 2, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2021

Codecov Report

Merging #716 (21a438e) into branch-21.10 (8e6ab70) will increase coverage by 1.80%.
The diff coverage is 67.27%.

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.10     #716      +/-   ##
================================================
+ Coverage         87.63%   89.43%   +1.80%     
================================================
  Files                15       15              
  Lines              1658     1704      +46     
================================================
+ Hits               1453     1524      +71     
+ Misses              205      180      -25     
Impacted Files Coverage Δ
dask_cuda/cuda_worker.py 77.64% <ø> (ø)
dask_cuda/local_cuda_cluster.py 77.88% <50.00%> (ø)
dask_cuda/utils.py 84.25% <60.52%> (-3.03%) ⬇️
dask_cuda/proxify_device_objects.py 94.30% <71.42%> (+5.42%) ⬆️
dask_cuda/initialize.py 92.59% <100.00%> (+3.70%) ⬆️
dask_cuda/is_device_object.py 92.59% <100.00%> (+29.62%) ⬆️
dask_cuda/proxify_host_file.py 99.41% <100.00%> (+0.02%) ⬆️
dask_cuda/explicit_comms/dataframe/shuffle.py 98.69% <0.00%> (+0.65%) ⬆️
dask_cuda/proxy_object.py 90.73% <0.00%> (+1.08%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a077463...21a438e. Read the comment docs.

Copy link
Member

@madsbk madsbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @galipremsagar!

dask_cuda/proxify_device_objects.py Show resolved Hide resolved
@galipremsagar
Copy link
Contributor Author

@gpucibot merge

2 similar comments
@galipremsagar
Copy link
Contributor Author

@gpucibot merge

@pentschev
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 5bd08f3 into rapidsai:branch-21.10 Sep 8, 2021
@pentschev
Copy link
Member

Thanks @galipremsagar !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Non-breaking change python python code needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Failure when performing ORDER BY desc query with JIT_UNSPILL enabled
5 participants