Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Distributed tests from CI #699

Merged

Conversation

pentschev
Copy link
Member

Now that Distributed runs GPU tests in CI, running them here is redundant and can be removed.

@pentschev pentschev requested a review from a team as a code owner August 9, 2021 15:51
@github-actions github-actions bot added the gpuCI gpuCI issue label Aug 9, 2021
@pentschev pentschev added 3 - Ready for Review Ready for review by team non-breaking Non-breaking change proposal A code change suggestion to be considered or discussed feature request New feature or request labels Aug 9, 2021
@pentschev
Copy link
Member Author

@quasiben @charlesbluca could you take a look at this and let me know if there's any reason why we shouldn't do it now? I think all of the tests are now being properly executed in Distributed's repo, so they're probably not required here anymore. Note that the same tests are running in the UCX-Py repo, I'm leaving them there for now because we test both the UCX 1.9 conda package and the 1.11 build from source.

@pentschev
Copy link
Member Author

rerun tests

@charlesbluca
Copy link
Member

I think these should be good to remove - would it be worth it to add something like UCX_VER to the Dask/Distributed test/image matrix moving forward, or is that less of a priority since UCX-Py is getting upstreamed?

@pentschev
Copy link
Member Author

I think these should be good to remove - would it be worth it to add something like UCX_VER to the Dask/Distributed test/image matrix moving forward, or is that less of a priority since UCX-Py is getting upstreamed?

The problem is that today we need to build UCX 1.11 from source, which is done during the CI build script, and this is something I would not like to do in Distributed CI to prevent unexpected failures from blocking CI there. Once we officially upgrade to UCX 1.11 and build conda packages for it we don't need to keep testing both versions, then we can just use the 1.11 package in Distributed and remove Distributed tests from UCX-Py as well.

@pentschev
Copy link
Member Author

Thanks @charlesbluca for comment and @ajschmidt8 for approval. Merging.

@pentschev
Copy link
Member Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit b5d0f8b into rapidsai:branch-21.10 Aug 11, 2021
@pentschev pentschev deleted the remove-ci-distributed-test branch August 12, 2021 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team feature request New feature or request gpuCI gpuCI issue non-breaking Non-breaking change proposal A code change suggestion to be considered or discussed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants