Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin max dask & distributed versions #686

Merged
merged 6 commits into from
Jul 27, 2021

Conversation

galipremsagar
Copy link
Contributor

Changes to be in-line with: rapidsai/cudf#8859

@galipremsagar galipremsagar requested a review from a team as a code owner July 27, 2021 17:19
@github-actions github-actions bot added the conda conda issue label Jul 27, 2021
@jakirkham jakirkham added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jul 27, 2021
@jakirkham
Copy link
Member

rerun tests

1 similar comment
@jakirkham
Copy link
Member

rerun tests

@pentschev
Copy link
Member

The failure is because CI still installs Dask/Distributed main branch, and there's now some changes in Distributed on UCX variable name changing that need to be resolved in Dask-CUDA. I opened #687 to avoid installing Dask from main branch and will revert that in 21.10 after that PR is merged.

@ajschmidt8
Copy link
Member

rerun tests

@pentschev
Copy link
Member

#687 is in, rerunning tests now.

@pentschev
Copy link
Member

rerun tests

@codecov-commenter
Copy link

codecov-commenter commented Jul 27, 2021

Codecov Report

Merging #686 (3765161) into branch-21.08 (14b8d63) will increase coverage by 29.90%.
The diff coverage is n/a.

❗ Current head 3765161 differs from pull request most recent head dc54b29. Consider uploading reports for the commit dc54b29 to get more accurate results
Impacted file tree graph

@@                Coverage Diff                @@
##           branch-21.08     #686       +/-   ##
=================================================
+ Coverage         60.19%   90.10%   +29.90%     
=================================================
  Files                21       15        -6     
  Lines              2618     1657      -961     
=================================================
- Hits               1576     1493       -83     
+ Misses             1042      164      -878     
Impacted Files Coverage Δ
dask_cuda/benchmarks/local_cudf_merge.py
dask_cuda/benchmarks/local_cupy_map_overlap.py
dask_cuda/benchmarks/local_cudf_shuffle.py
dask_cuda/_version.py
dask_cuda/benchmarks/local_cupy.py
dask_cuda/benchmarks/utils.py
dask_cuda/explicit_comms/dataframe/shuffle.py 98.69% <0.00%> (+0.65%) ⬆️
dask_cuda/proxy_object.py 90.73% <0.00%> (+1.08%) ⬆️
dask_cuda/utils.py 88.58% <0.00%> (+1.31%) ⬆️
dask_cuda/cli/dask_cuda_worker.py 97.14% <0.00%> (+1.42%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14b8d63...dc54b29. Read the comment docs.

@jakirkham
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit a0217f4 into rapidsai:branch-21.08 Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conda conda issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants