Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip test_get_ucx_net_devices_raises on UCX >= 1.11.0 #685

Conversation

pentschev
Copy link
Member

No description provided.

@pentschev pentschev requested a review from a team as a code owner July 26, 2021 22:18
@github-actions github-actions bot added the python python code needed label Jul 26, 2021
@pentschev pentschev added 3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Non-breaking change labels Jul 26, 2021
@pentschev
Copy link
Member Author

@gpucibot merge

@pentschev
Copy link
Member Author

rerun tests

@pentschev
Copy link
Member Author

rerun tests

@codecov-commenter
Copy link

codecov-commenter commented Jul 27, 2021

Codecov Report

Merging #685 (b22fc5a) into branch-21.08 (14b8d63) will increase coverage by 29.90%.
The diff coverage is n/a.

❗ Current head b22fc5a differs from pull request most recent head 1b8e1bb. Consider uploading reports for the commit 1b8e1bb to get more accurate results
Impacted file tree graph

@@                Coverage Diff                @@
##           branch-21.08     #685       +/-   ##
=================================================
+ Coverage         60.19%   90.10%   +29.90%     
=================================================
  Files                21       15        -6     
  Lines              2618     1657      -961     
=================================================
- Hits               1576     1493       -83     
+ Misses             1042      164      -878     
Impacted Files Coverage Δ
dask_cuda/benchmarks/local_cupy_map_overlap.py
dask_cuda/_version.py
dask_cuda/benchmarks/local_cudf_merge.py
dask_cuda/benchmarks/local_cudf_shuffle.py
dask_cuda/benchmarks/local_cupy.py
dask_cuda/benchmarks/utils.py
dask_cuda/explicit_comms/dataframe/shuffle.py 98.69% <0.00%> (+0.65%) ⬆️
dask_cuda/proxy_object.py 90.73% <0.00%> (+1.08%) ⬆️
dask_cuda/utils.py 88.58% <0.00%> (+1.31%) ⬆️
dask_cuda/cli/dask_cuda_worker.py 97.14% <0.00%> (+1.42%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14b8d63...1b8e1bb. Read the comment docs.

@rapids-bot rapids-bot bot merged commit 85d86cb into rapidsai:branch-21.08 Jul 27, 2021
@pentschev pentschev deleted the skip-test_get_ucx_net_devices_raises branch August 12, 2021 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Non-breaking change python python code needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants