Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Fix assert_eq related imports #663

Merged
merged 4 commits into from
Jun 30, 2021
Merged

[REVIEW] Fix assert_eq related imports #663

merged 4 commits into from
Jun 30, 2021

Conversation

galipremsagar
Copy link
Contributor

Recently there has been a change of location of where the testing utils of cudf reside. This PR is adapting to those changes.

@galipremsagar galipremsagar requested a review from a team as a code owner June 30, 2021 20:06
@github-actions github-actions bot added the python python code needed label Jun 30, 2021
@galipremsagar
Copy link
Contributor Author

Could someone label this PR as I don't have the permissions to do so in this repo?

@charlesbluca charlesbluca added bug Something isn't working 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels Jun 30, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jun 30, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.08@66b7795). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 3bdf972 differs from pull request most recent head fd77fd3. Consider uploading reports for the commit fd77fd3 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.08     #663   +/-   ##
===============================================
  Coverage                ?   90.32%           
===============================================
  Files                   ?       15           
  Lines                   ?     1644           
  Branches                ?        0           
===============================================
  Hits                    ?     1485           
  Misses                  ?      159           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66b7795...fd77fd3. Read the comment docs.

@charlesbluca charlesbluca mentioned this pull request Jun 30, 2021
Closed
pentschev
pentschev approved these changes Jun 30, 2021
View reviewed changes
Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thansk @galipremsagar !

@pentschev
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 79bc44e into rapidsai:branch-21.08 Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlesbluca charlesbluca charlesbluca approved these changes

@pentschev pentschev pentschev approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Non-breaking change python python code needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@galipremsagar @codecov-commenter @pentschev @charlesbluca